Walkthrough

Added two resets of the systemd journal data cursor/decompression state in the systemd input plugin and set static libzstd visibility to hidden in the bundled zstd CMake build.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Reader as in_systemd_collect
    participant Journal as sd_journal

    Note over Reader,Journal #EFEFEF: Per-entry processing (new calls highlighted)
    Reader->>Journal: sd_journal_next() / advance to next entry
    Reader->>Journal: sd_journal_restart_data()    -- reset decompression/cursor
    Reader->>Journal: sd_journal_enumerate_data()  -- enumerate fields
    Reader->>Journal: sd_journal_restart_data()    -- ensure fresh enumeration state
    alt field data present
        Journal-->>Reader: field data items
    else no data / end
        Journal-->>Reader: no more fields
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

• Heterogeneous changes: one small runtime change in plugin logic, one build-system change affecting symbol visibility and linking.
• Pay attention to:
  • Correct placement and potential redundant calls of sd_journal_restart_data in plugins/in_systemd/systemd.c.
  • Build implications of hiding symbols in libzstd_static (linking, symbol collisions, consumers that expected visible inlines).
  • Reproduce/test on affected platforms (RHEL10/systemd versions) to validate crash regression.

Poem

🐰 I hop in code with careful paws,
I nudge the journal, mend its flaws.
A hidden coat for zstd's song,
Two tiny taps to keep logs strong.
Happy hops — the system hums along.

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Added another update to avoid zstd exporting symbols...

note: CI error is with CI Fuzz with credentials (already fixed in master)

Removed the zstd commit.